From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 4A3DF1EFD68; Thu, 14 Mar 2019 07:07:42 -0400 (EDT) Authentication-Results: befuddled.reisers.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="oMleCQ1g"; dkim-atps=neutral Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by befuddled.reisers.ca (Postfix) with ESMTPS id 852F31EFD46 for ; Thu, 14 Mar 2019 07:07:39 -0400 (EDT) Received: by mail-wr1-x42a.google.com with SMTP id w2so5335054wrt.11 for ; Thu, 14 Mar 2019 04:07:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NyRzBln7MzLoKmOO/btQkbVGZnNv/sGRWxkDqVTAR28=; b=oMleCQ1gkLKioKXpHuOtcgsSVfeJIdj6qeaHOwMj+6csAulKEdshbcuUYzz0jS03xF aH0rfgcmSE/VF80fHMHBtfYBqW55tipkBmCJoE6mj4im7XbPy4HuLQ0cIPr8aV+TfXJl Rhej2alJDs96q5gz/NEuwAtOSrD3JYbqri53vWl9AjlY/V+NiK4EeNwNn0o804S8Qkmw Xmjr2Zid5oBCnSUnhDkVONFFkvNpLmeHThmgEhtFp3bE27r/LluokaD3sby+rytF1veb diJ112K3a9sb+puFAE+uXo45s7URaU020OZSotvuJWFSnizUlgJ484TKKiF45YiKCXrQ 2KgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NyRzBln7MzLoKmOO/btQkbVGZnNv/sGRWxkDqVTAR28=; b=qhs445YJm+u4EswcHwxyWTA30DtAtcCmNcrXOhesmaiCkDYqzhTGluWlUweWLdZxcX 9txE4FkDLqtNlXOLDqKT+IrqeysGcDLw5u9Z/NIi+dArjvmWlgOsc8EiotcLqeQ29X8o dFLshrk2u9H/7sPaqbFJ5CNNhApz7EfE1+1N277f8sbQic1xjonhDwyBSb9C8PHRBexA DgznkMcpdFWNtPZxoa3r15kA2h5FcZ6Ck5Y31FeLgMfUbEx/e8cFFvcRl9j2tSML4PyS DmB2DojONXKb5J9HWj/W/Q+EhiFMMYFmxsaZRnKMh4LPHu3GbYuDodD31OYdERkkAu6S ydcA== X-Gm-Message-State: APjAAAVFKaJOxUSZ+pTxh513JWx2k1OfXNkIKFYhQxR4g8S17la7Uu6k HYxiA+E40YbuXR/O1VPGhE4= X-Google-Smtp-Source: APXvYqzZ1Llq6knql8b0pwp90yenUr5qLa4ceL5y0bTzDMBHQXJdeLAMWnY9F4sZ/TSjdxFQesH/+Q== X-Received: by 2002:a05:6000:8b:: with SMTP id m11mr30113510wrx.243.1552561657446; Thu, 14 Mar 2019 04:07:37 -0700 (PDT) Received: from narunkot ([94.11.212.65]) by smtp.gmail.com with ESMTPSA id e12sm16629679wrs.91.2019.03.14.04.07.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2019 04:07:36 -0700 (PDT) Date: Thu, 14 Mar 2019 11:07:26 +0000 From: Okash Khawaja To: Samuel Thibault Cc: speakup@linux-speakup.org, William Hubbs Subject: Re: TODO file Message-ID: <20190314110726.3bcc7bcf@narunkot> In-Reply-To: <20190312220915.qgtag5vezpaouoxp@function> References: <20190312202652.1e386ddf@narunkot> <20190312220915.qgtag5vezpaouoxp@function> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2019 11:07:42 -0000 On Tue, 12 Mar 2019 23:09:15 +0100 Samuel Thibault wrote: > Okash Khawaja, le mar. 12 mars 2019 20:26:52 +0000, a ecrit: > > For now, I wanted to ask how much of this part is still to be done: > > > > "The first issue has to do with the way speakup communicates with > > serial ports. Currently, we communicate directly with the hardware > > ports. This however conflicts with the standard serial port > > drivers, which poses various problems. This is also not working for > > modern hardware such as PCI-based serial ports. Also, there is not > > a way we can communicate with USB devices. The current serial port > > handling code is in serialio.c in this directory." > > You have done it all :) > > (even if, as you mentioned, the USB auto-probing would now be great) > > Samuel Great, thanks. At the end of this exercise, I'll update TODO file and add usb auto-probing to it. Regarding: "Some places are currently using in_atomic() because speakup functions are called in various contexts, and a couple of things can't happen in these cases. Pushing work to some worker thread would probably help, as was already done for the serial port driving part." I can't find any reference to in_atomic() in speakup code. According to "Atomic context and kernel API design" [1] lwn article, in_atomic() started being phased out of general kernel code around 2.6.26. I guess this commit removed remaining references to in_atomic: d7500135802c "Staging: speakup: Move pasting into a work item". Is there any more work to be done for this? Also can someone give a bit of a background or pointers regarding moving kobjects: "The kobjects may have to move to a more proper place in /sys. The discussion on lkml resulted to putting speech synthesizers in the "speech" class, and the speakup screen reader itself into /sys/class/vtconsole/vtcon0/speakup, the nasty path being handled by userland tools." Thanks, Okash [1] https://lwn.net/Articles/274695/