From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 396011EF983; Mon, 17 Jul 2017 17:09:15 -0400 (EDT) Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by befuddled.reisers.ca (Postfix) with ESMTPS id 9E0F81EF958 for ; Mon, 17 Jul 2017 17:09:13 -0400 (EDT) Received: by mail-wr0-f180.google.com with SMTP id w4so990231wrb.2 for ; Mon, 17 Jul 2017 14:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:user-agent:date:from:to:cc:subject:references :mime-version:content-disposition; bh=cTvQrvJ6WlQMhHJd7P+B20KXlrCL5x4G3MuQbuQV8jw=; b=BjtpMIqM/uYEUA2q+qIxIJcZ7XCEa6FusaT2meVoCqHSfat92u5WCh3L0b6NPMkfEB d0nH4YIPu55/Raj6vtJeG047EhRAeojOtv1JHImqjrepJ1gSUxzfRCrXlxMen+LT2e9d SgZtrsE/TgkVEQnYJoNDwygtH1tXoDMkhkoS3mjY/stKhpz/0OA8Zy3BIw5UfEBaGT4M tij11vazZnNu3shfBI9QJuHbmU4WDeediQJbIbTI6tHfXM6fI+7aGjfoLldYhpNuumvZ mQFX+scvZSO2Xs3au06E2TulEk7bbuLWf8fJcd5TW3WcYDnoz20m7qLg53sVITQRtTDO APUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:user-agent:date:from:to:cc:subject :references:mime-version:content-disposition; bh=cTvQrvJ6WlQMhHJd7P+B20KXlrCL5x4G3MuQbuQV8jw=; b=QEEUZQ9NtjNNg480xossDYzPYvie4tbrEr8Ay3LwPYHjaBagWBbHYuzvKCXb195mqV koZopzEHQ5UrmHnaMsfrn/x2w72DE0e/mDNSIQVCybKhlFXbDEwaSdo4FONQ5uzHVJ6k 5ykx1QBumYqqARygC6aiiSyAVvRQ92MVlSCN8VduVu+/+KyAlERBF2356Zkm+wWVpgpb yIRirf/7DPNkUiK9VeU6ed3YVP8/1ywxySMV5uiTZOsQXsKFI7V2xt9L71GLIDuBU/+e TGz2Lm72dfLOko2BCM7HVzEgkToobizMZDd3iPBp+VcsDJ3NDqiH/zC+VkvYMwOlW1Hh dc9g== X-Gm-Message-State: AIVw112gN36h1y851XYsBPz9k4ZQAhInDBKTFcHmWKtCM+pBiY3KX/O3 JpNYS35Lv7DSxQ== X-Received: by 10.28.48.201 with SMTP id w192mr5538734wmw.28.1500325691465; Mon, 17 Jul 2017 14:08:11 -0700 (PDT) Received: from sanghar.laptop ([2a00:23c4:7320:5900:224:d6ff:fe76:7136]) by smtp.gmail.com with ESMTPSA id e125sm10746552wmd.25.2017.07.17.14.08.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Jul 2017 14:08:10 -0700 (PDT) Received: by sanghar.laptop (sSMTP sendmail emulation); Mon, 17 Jul 2017 22:08:08 +0100 Message-Id: <20170717210808.888502350@gmail.com> User-Agent: quilt/0.65 Date: Mon, 17 Jul 2017 22:04:54 +0100 From: Okash Khawaja To: Greg Kroah-Hartman , Jiri Slaby , Samuel Thibault , Alan Cox , linux-kernel@vger.kernel.org Cc: William Hubbs , Chris Brannon , Kirk Reiser , speakup@linux-speakup.org, devel@driverdev.osuosl.org, Okash Khawaja Subject: [patch v2 3/3] tty: undo export of tty_open_by_driver References: <20170717123145.GE24503@kroah.com> <20170717210451.026152929@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Disposition: inline; filename=21_undo_export_of_tty_open_by_driver X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jul 2017 21:09:15 -0000 Since we have tty_kopen, we no longer need to export tty_open_by_driver. This patch makes this function static. Signed-off-by: Okash Khawaja --- drivers/tty/tty_io.c | 3 +-- include/linux/tty.h | 5 ----- 2 files changed, 1 insertion(+), 7 deletions(-) --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -1851,7 +1851,7 @@ EXPORT_SYMBOL_GPL(tty_kopen); * - concurrent tty driver removal w/ lookup * - concurrent tty removal from driver table */ -struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode, +static struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode, struct file *filp) { struct tty_struct *tty; @@ -1902,7 +1902,6 @@ out: tty_driver_kref_put(driver); return tty; } -EXPORT_SYMBOL_GPL(tty_open_by_driver); /** * tty_open - open a tty device --- a/include/linux/tty.h +++ b/include/linux/tty.h @@ -400,8 +400,6 @@ extern struct tty_struct *get_current_tt /* tty_io.c */ extern int __init tty_init(void); extern const char *tty_name(const struct tty_struct *tty); -extern struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode, - struct file *filp); extern struct tty_struct *tty_kopen(dev_t device); extern int tty_dev_name_to_number(const char *name, dev_t *number); #else @@ -424,9 +422,6 @@ static inline int __init tty_init(void) { return 0; } static inline const char *tty_name(const struct tty_struct *tty) { return "(none)"; } -static inline struct tty_struct *tty_open_by_driver(dev_t device, - struct inode *inode, struct file *filp) -{ return NULL; } static inline struct tty_struct *tty_kopen(dev_t device) { return ERR_PTR(-ENODEV); } static inline int tty_dev_name_to_number(const char *name, dev_t *number)