public inbox for speakup@linux-speakup.org
 help / color / mirror / Atom feed
From: Okash Khawaja <okash.khawaja@gmail.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: "speakup@linux-speakup.org" <speakup@linux-speakup.org>
Subject: Re: unaddressed issues around tty_open_by_driver
Date: Thu, 29 Jun 2017 09:59:30 +0100	[thread overview]
Message-ID: <20170629085930.GA27335@sanghar> (raw)
In-Reply-To: <20170628202756.GA4213@sanghar>

On Wed, Jun 28, 2017 at 09:27:56PM +0100, Okash Khawaja wrote:
> Here's what I mean. I've done some rudimentary testing. It seems to
> clean up alright, allowing ttyUSB0 or ttyS0 to be reused by user space
> programs. It also prevents user program from using the tty held by
> speakup while speakup is loaded.
> 
> We don't need tty_kclose though because we can instead call
> tty_release_struct which will free up the tty, removing the need to
> clear TTY_KOPENED flag.
Thinking of raising this on wider mailing list - basically same that we
submitted the patch for exporting tty_open_by_driver to. If that makes
sense.

Thanks,
Okash

      reply	other threads:[~ UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
 Okash Khawaja
 ` Samuel Thibault
   ` Okash Khawaja
     ` Samuel Thibault
       ` Okash Khawaja
         ` Samuel Thibault
           ` Okash Khawaja
             ` Okash Khawaja
               ` Okash Khawaja [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170629085930.GA27335@sanghar \
    --to=okash.khawaja@gmail.com \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=speakup@linux-speakup.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).