public inbox for speakup@linux-speakup.org
 help / color / mirror / Atom feed
From: Okash Khawaja <okash.khawaja@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	Kirk Reiser <kirk@reisers.ca>,
	speakup@linux-speakup.org, Chris Brannon <chris@the-brannons.com>
Subject: Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t
Date: Mon, 19 Jun 2017 06:39:21 +0100	[thread overview]
Message-ID: <20170619053921.GA389@sanghar> (raw)
In-Reply-To: <20170619011533.GA11287@kroah.com>

On Mon, Jun 19, 2017 at 09:15:33AM +0800, Greg Kroah-Hartman wrote:
> > +int ser_to_dev(int ser, dev_t *dev_no)
> > +{
> > +	if (ser < 0 || ser > (255 - 64)) {
> > +                pr_err("speakup: Invalid ser param. \
> > +				Must be between 0 and 191 inclusive.\n");
> 
> As Andy pointed out, never do this for a C string, it's not doing what
> you think it is :)
Of course! I am sorry I should address such issues before submitting.
Will watch out more carefully next time.

> 
> Worse case, do this like the following:
> 		pr_err("speakup: Invalid ser param."
> 			"Must be between 0 and 191 inclusive.\n");
> 
> Also note, you are using spaces here in the patch, always run
> checkpatch.pl on your patches, so you don't get a grumpy maintainer
> telling you to run checkpatch.pl on your patches :)
Sure.

Thanks for the patience.

Okash

  parent reply	other threads:[~ UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
 [patch v2 0/3] staging: speakup: support more than ttyS* Okash Khawaja
 ` [patch v2 1/3] tty: add function to convert device name to number Okash Khawaja
     [not found]   ` <CAHp75VdrS=aSZvg2LwxwV0sR03SQb6do=aG5KGmgs1WKyvDirg@mail.gmail.com>
     ` Okash Khawaja
 ` [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t Okash Khawaja
     [not found]   ` <CAHp75Vfg=ahXP1tGQnzgRRjHczhHA36YT9aDLP6rvwk_hoew1A@mail.gmail.com>
     ` Okash Khawaja
     [not found]   ` <20170619011533.GA11287@kroah.com>
     ` Okash Khawaja [this message]
 ` [patch v2 3/3] staging: speakup: make ttyio synths use device name Okash Khawaja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170619053921.GA389@sanghar \
    --to=okash.khawaja@gmail.com \
    --cc=chris@the-brannons.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=kirk@reisers.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=speakup@linux-speakup.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).