From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 53EBB1F0300; Sun, 18 Jun 2017 13:22:18 -0400 (EDT) Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by befuddled.reisers.ca (Postfix) with ESMTPS id 045221F02FC for ; Sun, 18 Jun 2017 13:22:13 -0400 (EDT) Received: by mail-wm0-x241.google.com with SMTP id 70so13112823wme.1 for ; Sun, 18 Jun 2017 10:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BR/xkyD+vCwTQhMUY26XFulkTNGE/XUKSDru2uNrlrQ=; b=xU9+kmKn9/6+wRmZdfknPiB82GV1h3mFGmaau88d/PlquWrGCY8GZfm/UkXvQXXzVA IyRm3ZVGHuAMiiRk2yPRYBf1BwSNS4c+/4skynZJkJafwxLnvq6Bs4QosgFP2YhR+Esu iGpEm99JTQHbMTAA6FgHXGE/I9ByN6h9vWPkI6JxrhkkK7kFPWZ0rQnnBI5935RPPDjV Ko3J02phI6SnkxptieRgcvPlmPQkO0db6EQTOL9/18mYVfaS7YBJ8YllgJ6PBGVzn4mR 3e6mt3BdFhJU6rDNcOVolJJBP8gzGLRSloECx49mraBKCOPXYCZPEwg6/uUS2I0MEVkV +QIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BR/xkyD+vCwTQhMUY26XFulkTNGE/XUKSDru2uNrlrQ=; b=U0N1w5qTVDFfcuIj5rTkFKG8DmE5Vao0mixtDoNWDQXFeVF8zftkywyO7pe4MX3VMA anD51wnYfw7jBSAKkjlpQUhWZqf60pcRtX4RwrDxbVLysltGTM5uWgFE3wSvxpYDpMIf FK+UOA7rt7FgUZKMVftbTW/XF/siYjmSDo24VLCcXsREXHkMrQt5t8/PNU+PV19e8aDV cxLFz8ulyNVIZZlBoPwVIFcxQkM0pxenuIJyBFd7HJLCo4vp0W0iUKYdnSPuXbPTdVMN /sW0MmRxkhI/hgBLtRqbpJ+3ju5/c1mpGCRgEbGK5dSYaKUjKJfHhAMhVGrMK+4G81+u pG0w== X-Gm-Message-State: AKS2vOw4K3C4feI/ShE9XOSvpdj9yToIV4PCFSlmpjpFgtxSwcWSgLpK NDT1l+SrostdyA== X-Received: by 10.28.147.148 with SMTP id v142mr1783068wmd.1.1497806529863; Sun, 18 Jun 2017 10:22:09 -0700 (PDT) Received: from sanghar ([2a00:23c4:7320:5900:224:d6ff:fe76:7136]) by smtp.gmail.com with ESMTPSA id t15sm9901004wmd.13.2017.06.18.10.22.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Jun 2017 10:22:08 -0700 (PDT) Date: Sun, 18 Jun 2017 18:22:06 +0100 From: Okash Khawaja To: Andy Shevchenko Cc: Greg Kroah-Hartman , Jiri Slaby , Samuel Thibault , "linux-kernel@vger.kernel.org" , William Hubbs , Chris Brannon , Kirk Reiser , speakup@linux-speakup.org, devel@driverdev.osuosl.org Subject: Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t Message-ID: <20170618172206.GA393@sanghar> References: <20170618085825.601359240@gmail.com> <20170618093536.021961426@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 17:22:18 -0000 Hi, Thanks for the reviews. Couple of things inlined below. On Sun, Jun 18, 2017 at 04:35:21PM +0300, Andy Shevchenko wrote: > > > +const char *lp_supported[] = { "acntsa", "bns", "dummy", "txprt" }; > > static ? Sure! > > + if (ser < 0 || ser > (255 - 64)) { > > > + pr_err("speakup: Invalid ser param. \ > > + Must be between 0 and 191 inclusive.\n"); > > Just make it one line. Is it okay if it becomes larger than 80 chars? > > + > > + for (i = 0; i < ARRAY_SIZE(lp_supported); i++) { > > + if (strcmp(synth->name, lp_supported[i]) == 0) > > + break; > > + } > > + > > + if (i >= ARRAY_SIZE(lp_supported)) { > > match_string() Cool, didn't know about it > > > + pr_err("speakup: lp* is only supported on:"); > > > + for (i = 0; i < ARRAY_SIZE(lp_supported); i++) > > + pr_cont(" %s", lp_supported[i]); > > + pr_cont("\n"); > > pr_cont() is not the best idea, though I think it will be rare cases > when it might be broken in pieces. Hmm... I would like to keep it if it doesn't incur an overhead. It also indicates to the reader that this all part of same output line. Let me know what you think. > > > + > > + return -ENOTSUPP; > > + } > > + } > > + > > + return tty_dev_name_to_number(synth->dev_name, dev_no); > > + } > > + > > + return ser_to_dev(synth->ser, dev_no); > > +} > > + > > static int spk_ttyio_ldisc_open(struct tty_struct *tty) > > { > > struct spk_ldisc_data *ldisc_data; > > --- a/drivers/staging/speakup/spk_types.h > > +++ b/drivers/staging/speakup/spk_types.h > > @@ -169,6 +169,7 @@ struct spk_synth { > > int jiffies; > > int full; > > int ser; > > > + char *dev_name; > > const ? This becomes the target of module_param in following patch. It complains when set to const. Thanks! Okash