From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id E94A31F087A; Fri, 24 Mar 2017 15:22:09 -0400 (EDT) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by befuddled.reisers.ca (Postfix) with ESMTPS id 283CD1F0878 for ; Fri, 24 Mar 2017 15:22:08 -0400 (EDT) Received: by mail-wm0-x243.google.com with SMTP id u132so2497344wmg.1 for ; Fri, 24 Mar 2017 12:22:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2Fj1ui87oYxdYH7Fpw0ONl3MY1UrF3Wg6Obz4EpMQgY=; b=pY/qTK60U5wM+eGzU4uoa3IRgbw4tvSvqAu6S9Cm3R8wGcj43WXIJ+57F9Mq+vVtSS Y0zuiZeWUZ9yT7Q3XyaoB1DTE0sLNgQUP58oA+Rb1n+0sL4tqkybnto9odhK7z4jOUFR nQ2EC9AjrXkzV2lTUvlciP27Fd+xKnQYOzv/UJf/TVQ3zhyGGRRH2FAKYHpdlTvX9ozF HRte1WhXjXpEtsSiEvzyiLSY5i+x9AD2MwvyS06fh54UsnSTUzh4/CvBzFU+cb/T5Fsd x8HM2S3QXS+MtxfWDR45MvfmuGs8eZmrUxWy9fz092/UgIYL8bEwnnPsz8JLdfzsKnaO 5uHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2Fj1ui87oYxdYH7Fpw0ONl3MY1UrF3Wg6Obz4EpMQgY=; b=QXfPi/L2uzDuhG3X1yfD4qx2P66ct9EVZESl7LLtzxyY0qPttAy47oeNu5b25jBeJC 70KNPEDJjKlG/lP2nPxnhJ/xyvBBpPvOvB0qqiCBDUtzabvo4qKyZ+QVag9Wecx/Prar enBUDrhc95yKgG4mSim4RoJ4E8yrZbp9m5NSMzK36Emulw/iEk3Wq4mzwlAZV6nt64KN 01T6qGp41jQC0EIyA7y/gHz6+ztDHj+RbCq7E/DDWYefi5quJM81eFtV+XyUAfbjfIW7 3G4g5/b8dSKZJkttqhO1VUjhJYxjOtSFRMehJmsilVDdZ6Jvol4nxDGapi/U5iHh3cUu BZRA== X-Gm-Message-State: AFeK/H3zCw4V75m9BCJ1ESNINIIMBSHQiVs7nYvNDb90lZkc4ORAYmYg0vWmocoDnhO51Q== X-Received: by 10.28.24.16 with SMTP id 16mr4537111wmy.1.1490383318281; Fri, 24 Mar 2017 12:21:58 -0700 (PDT) Received: from sanghar (92.40.249.83.threembb.co.uk. [92.40.249.83]) by smtp.gmail.com with ESMTPSA id z15sm3642171wrz.67.2017.03.24.12.21.56 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 24 Mar 2017 12:21:57 -0700 (PDT) Date: Fri, 24 Mar 2017 19:21:54 +0000 From: Okash Khawaja To: Samuel Thibault Cc: speakup@linux-speakup.org Subject: Re: [patch 6/6] staging: speakup: Migrate acntsa, bns, dectlk and txprt to ttyio Message-ID: <20170324192154.GA2484@sanghar> References: <20170225192842.GA4519@sanghar> <20170225193031.GA4525@sanghar> <20170226025930.ftr43ridqfg3az5r@var.youpi.perso.aquilenet.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170226025930.ftr43ridqfg3az5r@var.youpi.perso.aquilenet.fr> User-Agent: Mutt/1.7.2 (2016-11-26) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 19:22:10 -0000 Hi, On Sun, Feb 26, 2017 at 03:59:30AM +0100, Samuel Thibault wrote: > Concerning speakup_apollo.c, it seems its only use of outb is to control > the modem RTS line. To support that, yet another step will be: > > - introduce spk_serial_tiocmset(unsigned int set, unsigned int clear), > which does: > > int old = inb(speakup_info.port_tts + UART_MCR); > outb((old & ~clear) | set, speakup_info.port_tts + UART_MCR); > > - introduce spk_ttyio_tiocmset(unsigned int set, unsigned int clear), > which does: > > speakup_tty->ops->tiocmset(speakup_tty, set, clear); > > and make them a tiocmset method of synths. > > and then in speakup_apollo.c, instead of > > outb(UART_MCR_DTR, speakup_info.port_tts + UART_MCR); > outb(UART_MCR_DTR | UART_MCR_RTS, > speakup_info.port_tts + UART_MCR); Is there a specific reason for keeping DTR set all the time? Or is it just a defensive measure? > > rather use > > synth->tiocmset(0, UART_MCR_RTS); > synth->tiocmset(UART_MCR_RTS, 0); > > Samuel