From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 46E4B1F09E0; Thu, 16 Mar 2017 02:52:10 -0400 (EDT) Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by befuddled.reisers.ca (Postfix) with ESMTPS id A81A41F09DB for ; Thu, 16 Mar 2017 02:52:08 -0400 (EDT) Received: by mail-wm0-x241.google.com with SMTP id x124so2378956wmf.3 for ; Wed, 15 Mar 2017 23:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QrPrODl6wNrm5LvQU0hQOnHm8bMLM+HXPdoNaK2iBA4=; b=FJaxtx8RbqPdVqT9fTeefgxlosyeZD0msxg+TJHfLjJ/QzvVlmQt/vSwUD9yOiAi6g WjrwoERoE6hBYoTGnFTyy3DxQg2jcwgZIUNgqtKvcnnsnKUbqxNfq6GpdFNQgcp8iL9l edREssjiJjLUEwHIyEmUU4wzxT7Own9iyeyVVPGc5ZmcyubolFiDrW16f6EpGOlYZCp0 l12O71C2CNKkDKRzfGrgjSDIay0NcD3WssT2cokFoaF6uUwtCseHGT10ZnPivzCFRMC0 SMpmJ/PJf1GzL5XPYIPVIGsteuGFUOYYQbpEk3K2TWSQeN9kXqzbpaR1C/mM6MCo3dyn 449w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QrPrODl6wNrm5LvQU0hQOnHm8bMLM+HXPdoNaK2iBA4=; b=sssNby29BmiaevCJbX8977T2IH33hSrwBuxEFW4QH+8DSatN9HbHPG3ll/SKpYJAc8 V7MePxZ0wdFA16gLxHlpnUs1GcF1IadEmhfPmx4UZAJ7d+gPzU3bGaxwub0MORj3JeqZ M4r52JuQqzat6dlWAcnALdLbQVR93gysomxfMlMyenO/NzHfB4OgzJFnRMZ95lUjtUVO I6yoV1W2dt/FGc9KFvLk0kgjHhjWRv+LvDNjq+99heBdNvYIBdV6QTVQeNStjNMSrgfu LLZ3fdw1QPdxuqjQ7ifdsYZjoiZfBBZMBqOiXpihOCweuoHOMVuNoY0ZmKTccSfTevCT jgXg== X-Gm-Message-State: AFeK/H0JriLh3z5sF2cJbUmLmwBnlALJnxY2SODV22uIguQC6lxSR94sBBF+IiuA9lbYGA== X-Received: by 10.28.28.69 with SMTP id c66mr24124498wmc.28.1489647121100; Wed, 15 Mar 2017 23:52:01 -0700 (PDT) Received: from sanghar (92.40.249.224.threembb.co.uk. [92.40.249.224]) by smtp.gmail.com with ESMTPSA id o52sm4961307wrb.51.2017.03.15.23.52.00 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Mar 2017 23:52:00 -0700 (PDT) Date: Thu, 16 Mar 2017 06:51:54 +0000 From: Okash Khawaja To: Greg Kroah-Hartman Cc: Samuel Thibault , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Kirk Reiser , speakup@linux-speakup.org, Chris Brannon Subject: Re: [patch 4/4] staging: speakup: move those functions which do outgoing serial comms, into serialio.c Message-ID: <20170316065154.GA756@sanghar> References: <20170314134151.603195427@gmail.com> <20170314134523.466213093@gmail.com> <20170316021409.GA26547@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170316021409.GA26547@kroah.com> User-Agent: Mutt/1.7.2 (2016-11-26) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Mar 2017 06:52:10 -0000 On Thu, Mar 16, 2017 at 11:14:09AM +0900, Greg Kroah-Hartman wrote: > On Tue, Mar 14, 2017 at 01:41:55PM +0000, Okash Khawaja wrote: > > This moves spk_synth_immediate and spk_serial_synth_probe functions into > > serialio.c. These functions do outgoing serial comms. The move is a step > > towards collecting all serial comms in serialio.c. This also renames > > spk_synth_immediate to spk_serial_synth_immediate. > > > > Code inside those functions has not been changed. Along the way, this patch > > also fixes a couple of spots which were calling spk_synth_immediate directly, > > so that the calls now happen via the spk_syth struct. > > > > Signed-off-by: Okash Khawaja > > Reviewed-by: Samuel Thibault > > > > Index: linux-4.11-rc2/drivers/staging/speakup/serialio.c > > This patch doesn't apply to my tree at all. The first 3 applied with > some fuzz, so I think you are not working against linux-next. Please > rebase your patch against linux-next, or my staging-testing branch, and > resend so I can apply it. Sure, will rebase against staging-testing. Just this patch or the patch set?