From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 141FC1F0B3A; Sat, 11 Mar 2017 08:08:24 -0500 (EST) Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) by befuddled.reisers.ca (Postfix) with ESMTPS id 2E2DA1F080E for ; Sat, 11 Mar 2017 08:06:18 -0500 (EST) Received: by mail-wm0-x232.google.com with SMTP id n11so12331233wma.1 for ; Sat, 11 Mar 2017 05:06:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:user-agent:date:from:to:cc:subject:mime-version :content-disposition; bh=0QeWvRiZeFEHPLDQ4xW3HeT01+V6700bdE2den7gtIY=; b=doBiwj/uO8zH6sYpIRnOlRC02/8BsV44IRjoXWYWhZHqkfv/a9IBJlrS3HVsNQGESq nIKNIoVXhsQP2k2/YoFPOyOeWFWwIKJLryEp26L7kYV2HgE25xxoD7cihITLVQKiGCnM jItvyxQOzPiLri+PeQFW7oPRJ8I5p1bDPKkogCBfnWxnzpm+x2XoPtK5DzYb7CX5A3QC qv8yRfuLXDnNwCUOj2O6TCcXhYJZfZs3D2A4+gq5rdSxnYEyAD5VlLbVkYDdPWoTaMpU 3+cRoxttvsPa6NjrmCNfEQ2+WgZp9Y5rTz4IiTSThuxndzI6nGWR3mapWWkShbg/FNCU JT4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:user-agent:date:from:to:cc:subject :mime-version:content-disposition; bh=0QeWvRiZeFEHPLDQ4xW3HeT01+V6700bdE2den7gtIY=; b=QCXlk+VDZLNxBjgI+MWXeXliUf+9/bD5fuuiU2TfTXu6S+Syg+1KqiIrbmIxBipxRF VXI0XDak0SghFZRRk3AHjeTMjAbnCGBaSkDNPbmwPoVao73bXbApZzQz8it018M88iGy WPHaWlz6yGTTPAx3pW+cl9i/y9PYveX0uok7p+UOpn++mzv/3yFXF+H5aZ9otRABNnfi oq/RwI4mPl4x6Q8KYZMeHTCN0c3a16RaJeygKnI6wcZt4HXOlbJzsgv2j7gACTDnMHzJ isYZn6d+9SRn41T91FCbLK8shck+o33ivooBDzvh/d8zhFezAOnvezc2mVpj2LS+StT3 ydcw== X-Gm-Message-State: AFeK/H3rKP3bkOgaE0nnulcfAnnrQxiJ8PHNEKFgpA8O7eiO3fPWA15k81JrnGVHR71zyA== X-Received: by 10.28.229.78 with SMTP id c75mr3313855wmh.20.1489237576098; Sat, 11 Mar 2017 05:06:16 -0800 (PST) Received: from sanghar (94.197.121.181.threembb.co.uk. [94.197.121.181]) by smtp.gmail.com with ESMTPSA id m201sm3597105wmd.19.2017.03.11.05.06.14 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 11 Mar 2017 05:06:15 -0800 (PST) Message-Id: <20170311130613.198207988@gmail.com> User-Agent: quilt/0.65 Date: Sat, 11 Mar 2017 13:05:25 +0000 From: okash.khawaja@gmail.com To: samuel.thibault@ens-lyon.org Cc: speakup@linux-speakup.org, Okash Khawaja Subject: [patch 1/7] tty_port: allow a port to be opened with a tty that has no file handle MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Disposition: inline; filename=01_enable_kernel_access_to_tty_device X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2017 13:08:24 -0000 Allow access to TTY device from kernel. This is based on Alan Cox's patch (http://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1215095.html), with description quoted below. "tty_port: allow a port to be opened with a tty that has no file handle Let us create tty objects entirely in kernel space. With this a kernel created non file backed tty object could be used to handle data, and set terminal modes. Not all ldiscs can cope with this as N_TTY in particular has to work back to the fs/tty layer. The tty_port code is however otherwise clean of file handles as far as I can tell as is the low level tty port write path used by the ldisc, the configuration low level interfaces and most of the ldiscs. Currently you don't have any exposure to see tty hangups because those are built around the file layer. However a) it's a fixed port so you probably don't care about that b) if you do we can add a callback and c) you almost certainly don't want the userspace tear down/rebuild behaviour anyway. This should however be sufficient if we wanted for example to enumerate all the bluetooth bound fixed ports via ACPI and make them directly available. It doesn't deal with the case of a user opening a port that's also kernel opened and that would need some locking out (so it returned EBUSY if bound to a kernel device of some kind). That needs resolving along with how you "up" or "down" your new bluetooth device, or enumerate it while providing the existing tty API to avoid regressions (and to debug)." Signed-off-by: Okash Khawaja Index: linux-4.10.1/drivers/tty/tty_io.c =================================================================== --- linux-4.10.1.orig/drivers/tty/tty_io.c +++ linux-4.10.1/drivers/tty/tty_io.c @@ -855,7 +855,7 @@ int tty_hung_up_p(struct file *filp) { - return (filp->f_op == &hung_up_tty_fops); + return (filp && filp->f_op == &hung_up_tty_fops); } EXPORT_SYMBOL(tty_hung_up_p); @@ -1368,7 +1368,10 @@ struct tty_struct *tty; if (driver->ops->lookup) - tty = driver->ops->lookup(driver, file, idx); + if (!file) + tty = ERR_PTR(-EIO); + else + tty = driver->ops->lookup(driver, file, idx); else tty = driver->ttys[idx]; @@ -1986,7 +1989,7 @@ struct tty_driver *console_driver = console_device(index); if (console_driver) { driver = tty_driver_kref_get(console_driver); - if (driver) { + if (driver && filp) { /* Don't let /dev/console block */ filp->f_flags |= O_NONBLOCK; break; @@ -2019,7 +2022,7 @@ * - concurrent tty driver removal w/ lookup * - concurrent tty removal from driver table */ -static struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode, +struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode, struct file *filp) { struct tty_struct *tty; @@ -2064,6 +2067,7 @@ tty_driver_kref_put(driver); return tty; } +EXPORT_SYMBOL(tty_open_by_driver); /** * tty_open - open a tty device Index: linux-4.10.1/drivers/tty/tty_port.c =================================================================== --- linux-4.10.1.orig/drivers/tty/tty_port.c +++ linux-4.10.1/drivers/tty/tty_port.c @@ -335,7 +335,7 @@ * tty_port_block_til_ready - Waiting logic for tty open * @port: the tty port being opened * @tty: the tty device being bound - * @filp: the file pointer of the opener + * @filp: the file pointer of the opener or NULL * * Implement the core POSIX/SuS tty behaviour when opening a tty device. * Handles: @@ -369,7 +369,7 @@ tty_port_set_active(port, 1); return 0; } - if (filp->f_flags & O_NONBLOCK) { + if (filp == NULL || filp->f_flags & O_NONBLOCK) { /* Indicate we are open */ if (C_BAUD(tty)) tty_port_raise_dtr_rts(port); Index: linux-4.10.1/include/linux/tty.h =================================================================== --- linux-4.10.1.orig/include/linux/tty.h +++ linux-4.10.1/include/linux/tty.h @@ -394,6 +394,8 @@ /* tty_io.c */ extern int __init tty_init(void); extern const char *tty_name(const struct tty_struct *tty); +extern struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode, + struct file *filp); #else static inline void console_init(void) { }