From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <samuel.thibault@ens-lyon.org>
Received: by befuddled.reisers.ca (Postfix, from userid 65534)
 id E82EC1F08AE; Sat, 28 Jan 2017 12:57:36 -0500 (EST)
Received: from hera.aquilenet.fr (hera.aquilenet.fr [IPv6:2a01:474::1])
 by befuddled.reisers.ca (Postfix) with ESMTP id 89F4A1F08A9
 for <speakup@linux-speakup.org>; Sat, 28 Jan 2017 12:57:35 -0500 (EST)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 8BF90A56F;
 Sat, 28 Jan 2017 18:57:31 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 4_k5D6aOcaK5; Sat, 28 Jan 2017 18:57:31 +0100 (CET)
Received: from var.youpi.perso.aquilenet.fr
 (AMontsouris-682-1-86-152.w90-87.abo.wanadoo.fr [90.87.249.152])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 0908DA46C;
 Sat, 28 Jan 2017 18:57:28 +0100 (CET)
Received: from samy by var.youpi.perso.aquilenet.fr with local (Exim 4.88)
 (envelope-from <samuel.thibault@ens-lyon.org>)
 id 1cXXFN-0006L0-Lx; Sat, 28 Jan 2017 18:57:09 +0100
Date: Sat, 28 Jan 2017 18:57:09 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Okash Khawaja <okash.khawaja@gmail.com>
Cc: "Speakup is a screen review system for Linux." <speakup@linux-speakup.org>
Subject: Re: Line discipline
Message-ID: <20170128175709.GO3304@var.home>
References: 
 <CAOtcWM3EQb8V7FtXcZdAjF=en-9L-nrMaRH7_TMTKLacOftwtw@mail.gmail.com>
 <20161220010836.GN2895@var.home>
 <F8D5D071-FE64-4447-A4FF-FC362246715F@gmail.com>
 <CAOtcWM27B_=F5xARtQXLj7iPbV8DcOKY4OLhnHc6FUH5YcTX8Q@mail.gmail.com>
 <20170124083045.GN2695@var.home>
 <CAOtcWM036GL=cDzoEmNM7KCTxNSpVwqe_k1O4cTCAWoTyA==5g@mail.gmail.com>
 <20170126001801.GQ3119@var.home>
 <CAOtcWM1N_k0MGhqn1S9wSuF2JPKrSjjPibRxtgMd0qzgV_e6Yg@mail.gmail.com>
 <20170126083312.GB25343@var.home>
 <CAOtcWM03ZjdDSA6LkoyDNj_EDijv0f_-CjKzyNWGpmh_4NWcew@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAOtcWM03ZjdDSA6LkoyDNj_EDijv0f_-CjKzyNWGpmh_4NWcew@mail.gmail.com>
User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
X-BeenThere: speakup@linux-speakup.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Speakup is a screen review system for Linux."
 <speakup.linux-speakup.org>
List-Unsubscribe: <http://linux-speakup.org/cgi-bin/mailman/options/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=unsubscribe>
List-Archive: <http://linux-speakup.org/pipermail/speakup/>
List-Post: <mailto:speakup@linux-speakup.org>
List-Help: <mailto:speakup-request@linux-speakup.org?subject=help>
List-Subscribe: <http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Jan 2017 17:57:37 -0000

Okash Khawaja, on Sat 28 Jan 2017 17:49:01 +0000, wrote:
> Added tty_ldisc_release() which resolved the problem.

Ok, good.

> Also added tty_ldisc_flush() before tty_ldisc_release().

I don't think it's really needed since the user is asking for speakup to
go away anyway, but it shouldn't hurt.

> Wouldn't it be safer to add those functions before tty_unlock()?

See callers of these, they don't lock the tty.

> The only output I get from speakup_dummy is:
> 
> Speakup
> RATE 8
> PITCH 8
> VOL 8
> TONE 8
> Dummy found

But are you working on the linux text console?

Samuel