From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 8E7FD1F0976; Thu, 26 Jan 2017 03:33:17 -0500 (EST) Received: from hera.aquilenet.fr (hera.aquilenet.fr [141.255.128.1]) by befuddled.reisers.ca (Postfix) with ESMTP id 9F2601F073B for ; Thu, 26 Jan 2017 03:33:16 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7860EA6BB; Thu, 26 Jan 2017 09:33:13 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OenlWl7iMtBm; Thu, 26 Jan 2017 09:33:13 +0100 (CET) Received: from var.youpi.perso.aquilenet.fr (unknown [IPv6:2a01:cb19:181:c200:3602:86ff:fe2c:6a19]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 063A1A2AB; Thu, 26 Jan 2017 09:33:12 +0100 (CET) Received: from samy by var.youpi.perso.aquilenet.fr with local (Exim 4.88) (envelope-from ) id 1cWfUW-00070c-9a; Thu, 26 Jan 2017 09:33:12 +0100 Date: Thu, 26 Jan 2017 09:33:12 +0100 From: Samuel Thibault To: Okash Khawaja Cc: "Speakup is a screen review system for Linux." Subject: Re: Line discipline Message-ID: <20170126083312.GB25343@var.home> References: <20161220010836.GN2895@var.home> <20170124083045.GN2695@var.home> <20170126001801.GQ3119@var.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jan 2017 08:33:17 -0000 Okash Khawaja, on Thu 26 Jan 2017 08:24:29 +0000, wrote: > >> +static void speakup_ldisc_close(struct tty_struct *tty) > >> +{ > >> + pr_warn("speakup_test_close()\n"); > > > > Does it get called at speakup_dummy removal time? > > No Ok. I guess what we are missing is some part of the rest of tty_release(). We notably seem to be lacking tty_ldisc_release(tty); between tty_unlock and tty_flush_works. Samuel