From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <samuel.thibault@ens-lyon.org>
Received: by befuddled.reisers.ca (Postfix, from userid 65534)
 id B20491EFD4D; Mon, 21 Nov 2016 17:36:36 -0500 (EST)
Received: from hera.aquilenet.fr (hera.aquilenet.fr [141.255.128.1])
 by befuddled.reisers.ca (Postfix) with ESMTP id A4FC01EFC1C
 for <speakup@linux-speakup.org>; Mon, 21 Nov 2016 17:36:35 -0500 (EST)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 705E3A6A8;
 Mon, 21 Nov 2016 23:36:32 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id Jnp8I5SIeqXo; Mon, 21 Nov 2016 23:36:32 +0100 (CET)
Received: from var.youpi.perso.aquilenet.fr (unknown
 [IPv6:2a01:cb19:181:c200:3602:86ff:fe2c:6a19])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id EA3F3A565;
 Mon, 21 Nov 2016 23:36:31 +0100 (CET)
Received: from samy by var.youpi.perso.aquilenet.fr with local (Exim 4.88)
 (envelope-from <samuel.thibault@ens-lyon.org>)
 id 1c8xCR-0002p2-HS; Mon, 21 Nov 2016 23:36:31 +0100
Date: Mon, 21 Nov 2016 23:36:31 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Okash Khawaja <okash.khawaja@gmail.com>
Cc: "Speakup is a screen review system for Linux." <speakup@linux-speakup.org>
Subject: Re: Line discipline
Message-ID: <20161121223631.GY2755@var.home>
References: 
 <CAOtcWM1y+uG=6_R-emNv7qo7oK+aHh05bzUHMWjOvzT3LCFgvQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAOtcWM1y+uG=6_R-emNv7qo7oK+aHh05bzUHMWjOvzT3LCFgvQ@mail.gmail.com>
User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
X-BeenThere: speakup@linux-speakup.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Speakup is a screen review system for Linux."
 <speakup.linux-speakup.org>
List-Unsubscribe: <http://linux-speakup.org/cgi-bin/mailman/options/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=unsubscribe>
List-Archive: <http://linux-speakup.org/pipermail/speakup/>
List-Post: <mailto:speakup@linux-speakup.org>
List-Help: <mailto:speakup-request@linux-speakup.org?subject=help>
List-Subscribe: <http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Nov 2016 22:36:36 -0000

Hello,

Okash Khawaja, on Mon 21 Nov 2016 22:32:52 +0000, wrote:
> 1. register ldisc structure in spk_tty_probe().

Registering the speakup line discipline should be done on speakup module
insertion (speakup_init), since we're supposed to do it just once.

> 2. in spk_tty_probe(), attach line discipline - like you would for /dev/ttyX
> from user space

spk_tty_probe also needs to open ttySX itsef.

> 3. in open() method of ldisc structure, take the tty_struct and cache it.

Yes.

> 4. in spk_serial_out_tty() call tty->ops->write() instead of outb().

Yes.

Samuel