From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <samuel.thibault@ens-lyon.org>
Received: by befuddled.reisers.ca (Postfix, from userid 65534)
 id B97851EFDF4; Fri, 18 Nov 2016 11:45:07 -0500 (EST)
Received: from hera.aquilenet.fr (hera.aquilenet.fr [141.255.128.1])
 by befuddled.reisers.ca (Postfix) with ESMTP id 6C4FB1EFDD2
 for <speakup@linux-speakup.org>; Fri, 18 Nov 2016 11:45:06 -0500 (EST)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 129B6A4F5;
 Fri, 18 Nov 2016 17:44:57 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id I3-3hJKUAtcE; Fri, 18 Nov 2016 17:44:56 +0100 (CET)
Received: from var.youpi.perso.aquilenet.fr (unknown
 [IPv6:2a01:cb19:181:c200:3602:86ff:fe2c:6a19])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 8C80797AA;
 Fri, 18 Nov 2016 17:44:56 +0100 (CET)
Received: from samy by var.youpi.perso.aquilenet.fr with local (Exim 4.87)
 (envelope-from <samuel.thibault@ens-lyon.org>)
 id 1c7mHX-00028c-DH; Fri, 18 Nov 2016 17:44:55 +0100
Date: Fri, 18 Nov 2016 17:44:55 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: David <david.a.borowski@gmail.com>
Cc: Okash Khawaja <okash.khawaja@gmail.com>,
 John Covici <covici@ccs.covici.com>,
 "Speakup is a screen review system for Linux." <speakup@linux-speakup.org>
Subject: Re: Serial: Initial refactor
Message-ID: <20161118164455.GA3422@var.home>
References: 
 <CAOtcWM3vOCSJ8UA9o6W9OC37G0j9ffkRGJ5JBAEfzOUcpGPhYw@mail.gmail.com>
 <20161118074407.GA6256@var.labri.fr>
 <CAOtcWM1AWKUP_prG9P6ggSwLjrw1yqAPrYxrBdFbMsNMhvK4jA@mail.gmail.com>
 <20161118123917.GC8282@var.labri.fr>
 <26E394E8-5AD1-415B-8194-D28D2A2C2EB0@gmail.com>
 <20161118144328.GA23992@db>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161118144328.GA23992@db>
User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
X-BeenThere: speakup@linux-speakup.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Speakup is a screen review system for Linux."
 <speakup.linux-speakup.org>
List-Unsubscribe: <http://linux-speakup.org/cgi-bin/mailman/options/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=unsubscribe>
List-Archive: <http://linux-speakup.org/pipermail/speakup/>
List-Post: <mailto:speakup@linux-speakup.org>
List-Help: <mailto:speakup-request@linux-speakup.org?subject=help>
List-Subscribe: <http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Nov 2016 16:45:07 -0000

David, on Fri 18 Nov 2016 09:43:28 -0500, wrote:
> Just add a few #defines in an #include file and there is no code
> change. #define spk_serial_out spk_serial_out2 etc.

It makes the code more complex for no benefit.

Changing the code is cheap. Making the code more complex costs a lot on
the long run.

Samuel