From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <samuel.thibault@ens-lyon.org>
Received: by befuddled.reisers.ca (Postfix, from userid 65534)
 id 17FC41EFD85; Wed,  5 Oct 2016 17:11:15 -0400 (EDT)
Received: from hera.aquilenet.fr (hera.aquilenet.fr [IPv6:2a01:474::1])
 by befuddled.reisers.ca (Postfix) with ESMTP id DF7F21EFD80
 for <speakup@linux-speakup.org>; Wed,  5 Oct 2016 17:11:13 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id E20239C69;
 Wed,  5 Oct 2016 23:11:11 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 8yf5MBH0KexN; Wed,  5 Oct 2016 23:11:11 +0200 (CEST)
Received: from var.youpi.perso.aquilenet.fr (unknown [89.225.205.178])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 6262E90F0;
 Wed,  5 Oct 2016 23:11:11 +0200 (CEST)
Received: from samy by var.youpi.perso.aquilenet.fr with local (Exim 4.87)
 (envelope-from <samuel.thibault@ens-lyon.org>)
 id 1brtT3-0002TT-Lx; Wed, 05 Oct 2016 23:11:09 +0200
Date: Wed, 5 Oct 2016 23:11:09 +0200
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Jitendra Khasdev <jkhasdev@gmail.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
 gregkh@linuxfoundation.org, bankarsandhya512@gmail.com,
 saurabh.truth@gmail.com, amitoj1606@gmail.com,
 speakup@linux-speakup.org, devel@driverdev.osuosl.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: speakup: Replaced obsolete simple_strtoul
Message-ID: <20161005211109.GD7253@var>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 Jitendra Khasdev <jkhasdev@gmail.com>, w.d.hubbs@gmail.com,
 chris@the-brannons.com, kirk@reisers.ca, gregkh@linuxfoundation.org,
 bankarsandhya512@gmail.com, saurabh.truth@gmail.com,
 amitoj1606@gmail.com, speakup@linux-speakup.org,
 devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
References: <1475699578-31474-1-git-send-email-jkhasdev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1475699578-31474-1-git-send-email-jkhasdev@gmail.com>
User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
X-BeenThere: speakup@linux-speakup.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Speakup is a screen review system for Linux."
 <speakup.linux-speakup.org>
List-Unsubscribe: <http://linux-speakup.org/cgi-bin/mailman/options/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=unsubscribe>
List-Archive: <http://linux-speakup.org/pipermail/speakup/>
List-Post: <mailto:speakup@linux-speakup.org>
List-Help: <mailto:speakup-request@linux-speakup.org?subject=help>
List-Subscribe: <http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Oct 2016 21:11:15 -0000

Hello,

Jitendra Khasdev, on Thu 06 Oct 2016 02:02:58 +0530, wrote:
> From: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
> 
> This patch is for replacing obsolete simple_strtoul to kstrtoul which remove warning produce by checkpatch.

> +	unsigned long val;
> +
> +	if (kstrtoul(start, 10, &val))
> +		return NULL;
>  
> -	val = simple_strtoul(skip_spaces(start), &start, 10);
>  	if (*start == ',')

simple_strtoul modifies start, so you can't just replace it with
kstrtoul.

Samuel