From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=WzbR=PH=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>
Received: by befuddled.reisers.ca (Postfix, from userid 65534)
 id 3A1411EF796; Fri, 11 Mar 2016 17:42:44 -0500 (EST)
Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138])
 by befuddled.reisers.ca (Postfix) with ESMTPS id E10021EF796
 for <speakup@linux-speakup.org>; Fri, 11 Mar 2016 17:42:42 -0500 (EST)
Received: from localhost (localhost [127.0.0.1])
 by sonata.ens-lyon.org (Postfix) with ESMTP id 3067A200F1;
 Fri, 11 Mar 2016 23:42:38 +0100 (CET)
Received: from sonata.ens-lyon.org ([127.0.0.1])
 by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id oojpMe8z5Xo1; Fri, 11 Mar 2016 23:42:38 +0100 (CET)
Received: from var.youpi.perso.aquilenet.fr
 (LFbn-1-6757-94.w90-120.abo.wanadoo.fr [90.120.189.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by sonata.ens-lyon.org (Postfix) with ESMTPSA id 69F54200EA;
 Fri, 11 Mar 2016 23:42:37 +0100 (CET)
Received: from samy by var.youpi.perso.aquilenet.fr with local (Exim 4.86_2)
 (envelope-from <samuel.thibault@ens-lyon.org>)
 id 1aeVlU-0008Ci-PY; Fri, 11 Mar 2016 23:42:36 +0100
Date: Fri, 11 Mar 2016 23:42:36 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Okash Khawaja <okash.khawaja@gmail.com>, w.d.hubbs@gmail.com,
 chris@the-brannons.com, kirk@reisers.ca, speakup@linux-speakup.org,
 devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: speakup: fix type mismatch warnings
Message-ID: <20160311224236.GH2786@var.home>
References: <20160310202135.GA30654@bytefire-computer>
 <20160311223252.GB31194@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160311223252.GB31194@kroah.com>
User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
X-BeenThere: speakup@linux-speakup.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "Speakup is a screen review system for Linux."
 <speakup.linux-speakup.org>
List-Unsubscribe: <http://linux-speakup.org/cgi-bin/mailman/options/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=unsubscribe>
List-Archive: <http://linux-speakup.org/pipermail/speakup/>
List-Post: <mailto:speakup@linux-speakup.org>
List-Help: <mailto:speakup-request@linux-speakup.org?subject=help>
List-Subscribe: <http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Mar 2016 22:42:44 -0000

Hello,

Greg KH, on Fri 11 Mar 2016 14:32:52 -0800, wrote:
> On Thu, Mar 10, 2016 at 08:21:35PM +0000, Okash Khawaja wrote:
> > Compiling speakup driver with sparse produces following warning:
> > 
> > drivers/staging/speakup/serialio.c:22:9: warning: incorrect type in
> > initializer (different base types)
> > drivers/staging/speakup/serialio.c:22:9:    expected unsigned int
> > [unsigned] flags
> > drivers/staging/speakup/serialio.c:22:9:    got restricted upf_t
> > 
> > This patch fixes it.
> > 
> > Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>

> > @@ -16,7 +17,7 @@ struct old_serial_port {
> >  	unsigned int baud_base;
> >  	unsigned int port;
> >  	unsigned int irq;
> > -	unsigned int flags; /* unused */
> > +	upf_t flags; /* unused */
> 
> I need some agreement from the speakup developers about this, I don't
> know if it's really needed or not...

It is not needed for functionality (upf_t is a typedef for unsigned
long), but in principle the field should be upf_t indeed (because it has
the __bitwise qualifier).

samuel