From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 365A91EFB49; Sun, 6 Mar 2016 17:02:54 -0500 (EST) Received: from mail-ob0-x22c.google.com (mail-ob0-x22c.google.com [IPv6:2607:f8b0:4003:c01::22c]) by befuddled.reisers.ca (Postfix) with ESMTPS id 517001EFB3F for ; Sun, 6 Mar 2016 17:02:52 -0500 (EST) Received: by mail-ob0-x22c.google.com with SMTP id fz5so91177641obc.0 for ; Sun, 06 Mar 2016 14:02:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=KPFEUZU7O39MdsnA3nPsxNeJLKAdRlGFmEhxGWu7mH0=; b=yd5aiGH7QUMqYV1MBBlmIamiagu/pQfdj2DKdncf6BeQcV+hr1vPIqc5fOUe5otkN+ TGRZD4P8sq7PfhB2eko2VOSWIYLKjsf9iPP7dtVg8e08BFqDCpaRAo4/Vp3t8jt7Yx1T wKcVYFWB4xNDUXGzn12QAdsYOp4hTP5kd8+NMYZ3pH9dhtGjW/lVqsL/joDSfLxQr84C 2csy/rnpbOzByjoF0FS4Jq3VyhtpQHWRzHIG8XwN8bg/EpNeetDDpqUXOsIkG4k31gM3 fIvgNHu6HC79WCSNQLop6wJ7nlgDIyoReYb0DBkHdGXpW0fmSC5VIxV63QamYsS4h0K9 S/uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=KPFEUZU7O39MdsnA3nPsxNeJLKAdRlGFmEhxGWu7mH0=; b=ImWc3a54bf1iPu/2S4WW0XPrHkSIJ60in/5MZq9GLtKeTzt2DxOj9uwD/xV1HQYxj0 0TyFaYQDsUXhfDMsBiX83ig7AFm7tlJrW/hUo1qGNA5CbHLLEC2j45CiijH5Vr7xoQ8D U9U605W8HWHt+KeOKmh8BnVVWgqpDXsDZZ1pZFAGdMRX5tfZd5+8Y86SNtTQu6NSKxHa 3uVmqcIQOPFU+PWUMjC+hugt+J4O1ebQSj/oBEWuJdPWxoZqmvjq4HeCm0cfcunmilqn TpN7thm/aXcMSPdfNslVAHbLaSr460VVf4EgSwO0ufCvVBSCpQDQaFQwvIysU0cLLvIb CMaA== X-Gm-Message-State: AD7BkJJRfGet+2yglr0KvBSeDQfzkE2nXJ1uIrW+h1rn9ALUkAzxE+pv0Fq0hRgO752SRg== X-Received: by 10.182.225.231 with SMTP id rn7mr12837626obc.2.1457301771184; Sun, 06 Mar 2016 14:02:51 -0800 (PST) Received: from linux1 (cpe-66-68-34-247.austin.res.rr.com. [66.68.34.247]) by smtp.gmail.com with ESMTPSA id ku6sm8622207obb.25.2016.03.06.14.02.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Mar 2016 14:02:50 -0800 (PST) Received: (nullmailer pid 7542 invoked by uid 1000); Sun, 06 Mar 2016 22:02:49 -0000 Date: Sun, 6 Mar 2016 16:02:49 -0600 From: William Hubbs To: "Speakup is a screen review system for Linux." Subject: Re: espeakup release coming soon Message-ID: <20160306220249.GA7506@linux1> Mail-Followup-To: "Speakup is a screen review system for Linux." , Samuel Thibault References: <20160306185459.GA6674@linux1> <20160306193717.GA2710@var.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20160306193717.GA2710@var.home> User-Agent: Mutt/1.5.24 (2015-08-30) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Mar 2016 22:02:54 -0000 Hi, do you know who wrote these patches? I would like to make sure I give proper credit in the logs. Thanks, William On Sun, Mar 06, 2016 at 08:37:17PM +0100, Samuel Thibault wrote: > Hello, >=20 > William Hubbs, on Sun 06 Mar 2016 12:54:59 -0600, wrote: > > I want to do a new espeakup release, hopefully in the next few days, so, > > I need to know if there are any patches that we need. Can folks take a > > look at it and let me know if anything is missing? >=20 > Good idea to ask :) >=20 > We have a few patches in Debian: >=20 > - keystrokes uses interpret-as=3D"characters" when the kernel reports just > one character. This allows to use espeak's internationalized spelling of > letters, instead of having to maintain spelling ourself in speakup. > - pidfile makes espeakup write the pidfile only after it is really > finished starting. We need this to properly report that the daemon > hasn't actually started when it failed to e.g. open voices. > - voice fixes using language names as espeakup parameter instead of > voice names, just like the espeak program does. >=20 > Samuel > Fix spelling keystrokes and char-by-char echo. >=20 > --- espeakup-0.71.orig/synth.c > +++ espeakup-0.71/synth.c > @@ -121,7 +121,29 @@ > { > espeak_ERROR rc; > =20 > - rc =3D espeak_Synth(s->buf, s->len + 1, 0, POS_CHARACTER, 0, 0, NULL, > - NULL); > + if (s->len =3D=3D 1) > + { > + char *buf; > + int n; > + n =3D asprintf(&buf, "%c", s->buf[0]); > + if (n =3D=3D -1) > + { > + /* D'oh. Not much to do on allocation failure. > + * Perhaps espeak will happen to say the character */ > + rc =3D espeak_Synth(s->buf, s->len + 1, 0, POS_CHARACTER, 0, 0, NULL, > + NULL); > + } > + else > + { > + rc =3D espeak_Synth(buf, n + 1, 0, POS_CHARACTER, 0, espeakSSML, NULL, > + NULL); > + free(buf); > + } > + } > + else > + { > + rc =3D espeak_Synth(s->buf, s->len + 1, 0, POS_CHARACTER, 0, 0, NULL, > + NULL); > + } > return rc; > } > Create pidfile after espeakup is really ready. >=20 > --- espeakup-0.71.orig/espeakup.c > +++ espeakup-0.71/espeakup.c > @@ -118,12 +118,6 @@ > if (!debug) { > /* become a daemon */ > daemon(0, 1); > - > - /* write our pid file. */ > - if (create_pid_file() < 0) { > - perror("Unable to create pid file"); > - return 2; > - } > } > =20 > /* initialize espeak */ > @@ -147,6 +141,14 @@ > return 4; > } > =20 > + if (!debug) { > + /* We are now ready, write our pid file. */ > + if (create_pid_file() < 0) { > + perror("Unable to create pid file"); > + return 2; > + } > + } > + > /* run the main loop */ > main_loop(&s); > =20 > --- a/synth.c > +++ b/synth.c > @@ -91,6 +91,13 @@ espeak_ERROR set_voice(struct synth_t * > espeak_ERROR rc; > =20 > rc =3D espeak_SetVoiceByName(voice); > + if (rc !=3D EE_OK) > + { > + espeak_VOICE voice_select; > + memset(&voice_select, 0, sizeof(voice_select)); > + voice_select.languages =3D voice; > + rc =3D espeak_SetVoiceByProperties(&voice_select); > + } > if (rc =3D=3D EE_OK) > strcpy(s->voice, voice); > return rc; > _______________________________________________ > Speakup mailing list > Speakup@linux-speakup.org > http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup