From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <w.d.hubbs@gmail.com>
Received: from mail-oa0-f42.google.com (mail-oa0-f42.google.com
 [209.85.219.42])
 by befuddled.reisers.ca (Postfix) with ESMTPS id A6A1E1EF6D5
 for <speakup@linux-speakup.org>; Thu,  9 May 2013 19:49:29 -0400 (EDT)
Received: by mail-oa0-f42.google.com with SMTP id i10so4262740oag.1
 for <speakup@linux-speakup.org>; Thu, 09 May 2013 16:49:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=x-received:date:from:to:subject:message-id:mail-followup-to
 :mime-version:content-type:content-disposition:user-agent;
 bh=MV+foQsYLpLn2Nd2pgGsNSVTSfQQRjoBzkFEXtQP2vQ=;
 b=QfU8qyNMEwelzupRgdoctueUr7l0pADyZTVeYN125k9eUBbUMgW7pLnCtLMi6nc87e
 QbcNQER5Ch+o/Ty1qI6QykhEi89PFnGY+6d7ZGKYe/IFoyOZJJpmNUClRE04K3gAHRon
 JlLog9MH5Irv13Hi9hMfQh2fG4177mGO/TGC20a/Zb+qg+VNvvbjOuhYIeWfvCs0Eap/
 wVU8Sp+gcDVM/SDU2ZajXCpP0l52l7rtqAFQQUBKBlxB0NRBELXjOvnz1aL4sw3F3bR6
 eDTmrya2PZSA6g9192ZmEAEF12WPCvrSIzfNPA1Ly85lcXT0jxNcGtF0UbpWk/lp77Ad
 y1VA==
X-Received: by 10.182.231.233 with SMTP id tj9mr3653619obc.68.1368143368540;
 Thu, 09 May 2013 16:49:28 -0700 (PDT)
Received: from linux1 (cpe-76-187-91-128.tx.res.rr.com. [76.187.91.128])
 by mx.google.com with ESMTPSA id ns4sm405565obc.2.2013.05.09.16.49.25
 for <speakup@linux-speakup.org>
 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Thu, 09 May 2013 16:49:27 -0700 (PDT)
Received: by linux1 (sSMTP sendmail emulation);
 Thu, 09 May 2013 18:49:15 -0500
Date: Thu, 9 May 2013 18:49:15 -0500
From: William Hubbs <w.d.hubbs@gmail.com>
To: speakup@linux-speakup.org
Subject: Fwd: Re: speakup issues
Message-ID: <20130509234915.GB2123@linux1>
Mail-Followup-To: speakup@linux-speakup.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: speakup@linux-speakup.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: "Speakup is a screen review system for Linux."
 <speakup@linux-speakup.org>
List-Id: "Speakup is a screen review system for Linux."
 <speakup.linux-speakup.org>
List-Unsubscribe: <http://linux-speakup.org/cgi-bin/mailman/options/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=unsubscribe>
List-Archive: <http://linux-speakup.org/pipermail/speakup/>
List-Post: <mailto:speakup@linux-speakup.org>
List-Help: <mailto:speakup-request@linux-speakup.org?subject=help>
List-Subscribe: <http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=subscribe>
X-List-Received-Date: Thu, 09 May 2013 23:49:29 -0000

----- Forwarded message from Dan Carpenter <dan.carpenter@oracle.com> -----

> Date: Thu, 9 May 2013 21:55:26 +0300
> From: Dan Carpenter <dan.carpenter@oracle.com>
> To: William Hubbs <w.d.hubbs@gmail.com>
> Cc: gregkh@suse.de, devel@driverdev.osuosl.org
> Subject: Re: speakup issues
> 
> It's like every function in speakup has something that's just a
> little bit ugly about it.
> 
> For example
> 1) No spaces around operations.  IE "if (x&4) {" vs "if (x & 4) {".
> 2) No blank lines between the variable declarations and the code.
> 3) The 'E' in E_DEFAULT stands for "enum" which is bogus.
> 4) Custom macros like spk_lock()
> 5) Using u_char instead of u8.  (Yes, there are thousands of places
>    in the kernel which do this but it's mostly horrid legacy code
>    like ISDN).
> 6) In synth_direct_store() the last 5 bytes of the tmp[] buf are not
>    used.
> 7) Unnecessary casts.
> 8) Things like this:
> 
> 	char *cp;
>         u_char *cp1;
> 
>    "cp1" is a poorly chosen variable name.
> 
> Anyway, there is a lot of stuff.  It just needs someone to go
> through it bit by bit and re-write it cleaner.
> 
> regards,
> dan carpenter
> 

----- End forwarded message -----