Re: [Edbrowse-dev] Disabling local echo for password fields

[Dominique Martinet <asmadeus@codewreck.org>]

Karl Dahlke wrote on Sun, Jul 09, 2017:
> I got the patch out of github, it will take a while to look through,
> not a lot of code but a lot of little changes all over the place.

Thank you; I was not sure on where to add code first so the code itself
was done quickly/is not polished.
If the place/global logic fits then it is a good start for me, I should
have been more explicit about that.

>  if (!cw->browseMode && (cmd == 'i' || cx)) {
> #  why query cmd and cx, neither has been set to anything at this point.
> #  cmd is the default p for print, I think.

Eep, you've caught some shameful copy/paste error here as I copied that
from the 'i' command block.
I had meant to only test browseMode (same for range)

>  setError(MSG_NoBrowse);
>  return false;
>  }
>  if (endRange > startRange && cmd == 'i') {
> #  again, cmd will not be set to i.
> #  Did you test all these cases?  1,3ipass will probably not fall into this
> #  block the way you want it to. You should test every pathway.
>  setError(MSG_RangeI, c);
> #  c has not been set.
> # setError(MSG_RangeI, '=');

MSG_RangeI is 'i' specific, we're going to need a new message (or make
the msg take a string as argument like fieldInputField)


> #  is cx set to 0 at this point? I think so.

yes


>  tagList[tagno]->itype = INP_PW;
> #  Hold it! I have a real problem overriding the html tag type.
> #  Mostly on philosophical grounds. I think others will as well.
> #  Chris says it is always password when it's suppose to be a password,
> #  almost always, so don't think we should change it.
> #  In an extreme case it could have been a select list, menu of choices,
> #  and now it's just a password text field and I'm sure that will
> #  make something blow up somewhere.

Right, I hadn't thought of radio and other type of fields as there
weren't any on the page I tested.
I agree something will likely break in that case, but I would like to
disable echo for informations entered with that even if the field is not
set -- I think in that case it makes more sense to revert INP_PW as a
minor type, I will implement that as you suggested in your earlier mail.

-- 
Dominique